Skip to content
This repository has been archived by the owner on Feb 25, 2023. It is now read-only.

Vertical text does not show popup anymore #1985

Closed
Shadowlauch opened this issue Oct 14, 2021 · 3 comments
Closed

Vertical text does not show popup anymore #1985

Shadowlauch opened this issue Oct 14, 2021 · 3 comments

Comments

@Shadowlauch
Copy link
Contributor

Description
When I am in a frame with only vertical text it will scan the text and highlight the word, but it will not show any popup. If there is any none vertical text it will show the popup even if you move over to the vertical text but it won't move the popup. This all worked yesterday.

First try scanning the vertical text: https://codepen.io/Shadowlauch/pen/porjyQJ

Browser version
Chrome 94.0.4606.81

Yomichan version
21.9.30.1

@Shadowlauch
Copy link
Contributor Author

After some additional probing I found out that this only happens if Vertical text positioning is not set to "Same as horizontal text"

@toasted-nutbread
Copy link
Collaborator

Thanks for finding this, I'll work on setting up a patch release.

@ttu-ttu
Copy link

ttu-ttu commented Oct 15, 2021

Edit 2: Didn't use "Same as horizontal text" when I test it on 21.9.30.2, still happening, but I now believe it's expected/intended behavior, now that I think about it

Edit: Was on 21.9.30.1, looks like it's fixed on 21.9.30.2

Also check if it goes off screen when the word wraps

(on Vertical text positioning -> Same as horizontal text)
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants