Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avalonia support #17

Closed
14 tasks done
gsomix opened this issue Feb 12, 2017 · 16 comments · Fixed by #325
Closed
14 tasks done

Avalonia support #17

gsomix opened this issue Feb 12, 2017 · 16 comments · Fixed by #325
Assignees

Comments

@gsomix
Copy link
Collaborator

gsomix commented Feb 12, 2017

Avalonia

TODO

@ForNeVeR
Copy link
Owner

It isn't still clear what kind of support we can offer to Avalonia. Probably we could add the control like your FormulaControl (see #23). Anyways, it seems that it depends on #18.

@gsomix gsomix self-assigned this Feb 22, 2017
@gsomix
Copy link
Collaborator Author

gsomix commented Feb 22, 2017

We can use drawing infrastructure of Avalonia that looks similar to WPF's one.

https://github.com/AvaloniaUI/Avalonia/tree/master/src/Avalonia.Visuals/Media

I will look into it later. And yes, I want to make a similar user control but for the xplat UI framework.

@Happypig375
Copy link

Would make sense to support Xamarin Forms at the same time too.

@ForNeVeR
Copy link
Owner

ForNeVeR commented Feb 1, 2018

Hello, @Happypig375!

Your request totally makes sense. Could you please raise another issue about Xamarin Forms? I'd like to support it, although I've no knowledge of Xamarin at all. I'd consider this request as up-for-grabs at the moment.

@ForNeVeR
Copy link
Owner

ForNeVeR commented Jan 13, 2019

Okay, here's the current plan.

@rstm-sf
Copy link
Contributor

rstm-sf commented Jan 19, 2020

Hello!

* make `FormulaBlock` public

Need to do just that? Or is it supposed to further improve the API?

I ask, because, as I understand it, we need to do this in order to upgrade to version 0.9 support:

System.MethodAccessException: 'Attempt by method 'AvaloniaMath.Example.Views.MainWindow.!XamlIlPopulate(System.IServiceProvider, AvaloniaMath.Example.Views.MainWindow)' to access method 'AvaloniaMath.Controls.FormulaBlock..ctor()' failed.'

Because

Class constructors and codebehind event handlers must be public
Avalonia / Breaking Changes / 0.8 -> 0.9 / XAML

P.S. I settled on the next in the switching to 0.9:

picture

@ForNeVeR
Copy link
Owner

@rstm-sf, initial plan is just make it public, but, if you have any particular improvements for API, then feel free to apply them and drop me a PR.

Regarding the Avalonia changes: I think it's okay to make the class and any constructors public.

Regarding 0.9 update: well, it looks bad. I understand that Avalonia may be pretty much unstable (especially its font-based API), and we'll have to struggle with the instability. I heard that some release of Avalonia (0.9.x? 0.10?) will receive more proper GlyphRun API, we may/should use that.

@ahopper
Copy link
Contributor

ahopper commented Jan 21, 2020

Hi sorry for my absence from this project, my initial use which faded may be starting up again. The 0.9.x release of Avalonia is very stable, the mods to text based stuff will probably happen between 0.9 and 0.10, How can I help?

ForNeVeR added a commit that referenced this issue Jan 30, 2023
ForNeVeR added a commit that referenced this issue Jan 30, 2023
ForNeVeR added a commit that referenced this issue Jan 31, 2023
ForNeVeR added a commit that referenced this issue Jan 31, 2023
ForNeVeR added a commit that referenced this issue Jan 31, 2023
ForNeVeR added a commit that referenced this issue Jan 31, 2023
Otherwise, tests may be unstable.
@ForNeVeR
Copy link
Owner

ForNeVeR commented Feb 1, 2023

Thank you so much, everyone. We did it!

The next release will likely have full Avalonia support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants