Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize TexPredefinedFormulaParser #339

Open
ForNeVeR opened this issue Jan 25, 2023 · 0 comments
Open

Optimize TexPredefinedFormulaParser #339

ForNeVeR opened this issue Jan 25, 2023 · 0 comments
Labels
help-wanted kind:refactoring

Comments

@ForNeVeR
Copy link
Owner

Currently, a new TexPredefinedFormulaParser is constructed for each TexFormulaParser (even if it is currently singleton in most cases), and then the TexFormulaParser is populated with the data from the TexPredefinedFormulaParser.

We could do better:

  • parse once
  • parse on demand?
  • get rid of these pesky signatures Func<SourceSpan, TexFormula?> in TexFormulaParser::predefinedFormulas.

When fixing this, look for TODO[#xxx] in the code.
ForNeVeR added a commit that referenced this issue Jan 25, 2023
@ForNeVeR
(#63, #338, #339, #340, #341) Code review changes
9c63d9e 
Clarify docs, change type visibility, fix namespaces, connect TODOs with
the issues.
ForNeVeR added a commit that referenced this issue Jan 25, 2023
@ForNeVeR
(#63, #338, #339, #340, #341) Code review changes
1054067 
Clarify docs, change type visibility, fix namespaces, connect TODOs with
the issues.
ForNeVeR added a commit that referenced this issue Jan 25, 2023
@ForNeVeR
(#63, #338, #339, #340, #341) Code review changes
cd3559b 
Clarify docs, change type visibility, fix namespaces, connect TODOs with
the issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help-wanted kind:refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ForNeVeR