Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: polished after doc review #51

Merged
merged 25 commits into from
May 23, 2024
Merged

Conversation

nicolasalexandre9
Copy link
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@nicolasalexandre9 nicolasalexandre9 force-pushed the feat/customize-error-message branch from eb24bd8 to 39e4a4b Compare May 22, 2024 15:16
matthv
matthv previously approved these changes May 23, 2024
Copy link
Member

@matthv matthv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@nicolasalexandre9 nicolasalexandre9 merged commit 055a153 into beta May 23, 2024
32 checks passed
@nicolasalexandre9 nicolasalexandre9 deleted the feat/customize-error-message branch May 23, 2024 09:22
forest-bot added a commit that referenced this pull request May 23, 2024
# [1.0.0-beta.49](v1.0.0-beta.48...v1.0.0-beta.49) (2024-05-23)

### Bug Fixes

* polished after doc review ([#51](#51)) ([055a153](055a153))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.0-beta.49 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants