fix: fix incorrect usage of the new connections parameter #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffladiray
approved these changes
Nov 26, 2020
| @@ -19,7 +19,7 @@ const HasManyDissociator = require('../src/services/has-many-dissociator'); | |||
| const models = {}; | |||
| const sequelizeOptions = { | |||
| Sequelize, | |||
| connections: [sequelize], | |||
| connections: { sequelize }, | |||
There was a problem hiding this comment.
Totally my fault, did not catch that during the review. This would have save us from this whole PR ...
| sort: '-id', | ||
| segmentQuery: 'select * from users\nwhere id in (100, 102);', | ||
| timezone: 'Europe/Paris', | ||
| }; | ||
| try { | ||
| const result = await new ResourcesGetter(models.user, sequelizeOptions, params) | ||
| .perform(); | ||
| expect(result).toHaveLength(2); | ||
| expect(result[0]).toHaveLength(2); |
There was a problem hiding this comment.
At least, we discovered that this test was not working for a while 🥇
arnaud-moncel
changed the title
forest-bot
added a commit
that referenced
this pull request
Nov 30, 2020
# [7.0.0-beta.2](v7.0.0-beta.1...v7.0.0-beta.2) (2020-11-30) ### Bug Fixes * fix incorrect usage of the new connections parameter ([#557](#557)) ([2840e41](2840e41))
|
🎉 This PR is included in version 7.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
forest-bot
added a commit
that referenced
this pull request
Feb 22, 2021
# [7.0.0](v6.7.11...v7.0.0) (2021-02-22) ### Bug Fixes * **authentication:** error when authenticating with an invalid token in cookies ([#593](#593)) ([405feb4](405feb4)) * connect to liana through safari ([#590](#590)) ([6a0fcb3](6a0fcb3)) * fix incorrect usage of the new connections parameter ([#557](#557)) ([2840e41](2840e41)) * user being disconnected after 33min instead of 14 days ([#591](#591)) ([2e2dc81](2e2dc81)) ### Features * init function now uses connections & objectMapping instead of sequelize as parameter ([#539](#539)) ([74262ac](74262ac)) * return correct errors when the user needs to configure the 2FA ([#609](#609)) ([08b64a0](08b64a0)) ### BREAKING CHANGES * sequelize options is not supported anymore by Liana.init() connections and objectMapping is now required on Liana.init(). Update forest-express dependency to 8.0.0-beta.1 (See https://github.com/ForestAdmin/forest-express/tree/v8.0.0-beta.1) Co-authored-by: jeffladiray <ladirayjeff@gmail.com>
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist: