Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(authentication): safari cannot login on remote lianas because of third party cookies #646

Merged
merged 1 commit into from
Mar 4, 2021
Merged

fix(authentication): safari cannot login on remote lianas because of third party cookies #646

merged 1 commit into from
Mar 4, 2021

Conversation

ghusse
Copy link
Contributor

@ghusse ghusse commented Mar 4, 2021

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@ghusse ghusse requested a review from LouisClisson March 4, 2021 15:53
LouisClisson
LouisClisson approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@LouisClisson LouisClisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅  Code review

🆗

✅  Automatic tests

Not needed here

✅  Manual tests

I test the google authentication and it worked as expected.

✅  PR title

🌈

✅ ⚠️ Destination branch

🆗

@ghusse ghusse merged commit 92f80b9 into master Mar 4, 2021
@ghusse ghusse deleted the fix/safari-3rd-party branch March 4, 2021 16:02
forest-bot added a commit that referenced this pull request Mar 4, 2021
@forest-bot
chore(release): 7.0.1 [skip ci]
a76fcc7 
## [7.0.1](v7.0.0...v7.0.1) (2021-03-04)

### Bug Fixes

* **authentication:** safari cannot login on remote lianas because of third party cookies ([#646](#646)) ([92f80b9](92f80b9))
@forest-bot
Copy link
Member

🎉 This PR is included in version 7.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouisClisson LouisClisson LouisClisson approved these changes

Assignees

@LouisClisson LouisClisson

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghusse @forest-bot @LouisClisson