Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dumper): ignore stats model name when generating/updating project to avoid route conflicts #216

Merged
merged 5 commits into from
Aug 25, 2021
Merged

fix(dumper): ignore stats model name when generating/updating project to avoid route conflicts #216

merged 5 commits into from
Aug 25, 2021

Conversation

jeffladiray
Copy link
Member

@jeffladiray jeffladiray commented Aug 25, 2021 •
edited
Loading

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • Test manually the implemented changes
  • Review my own code (syntax, style, simplicity, readability)

@jeffladiray jeffladiray changed the title fix(dumper): ignore stats model name when generating/updating project… fix(dumper): ignore stats model name when generating/updating project to avoid route conflicts Aug 25, 2021
@forest-bot
Copy link
Member

Task linked: CU-1cym1f0 P3 - Agents - Live query charts fails with 403 when there is a collection named "stats" with "createEnabled" false

@jeffladiray jeffladiray requested a review from slimee August 25, 2021 08:09
@jeffladiray jeffladiray marked this pull request as ready for review August 25, 2021 08:09
slimee
slimee approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@slimee slimee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 you are a great machine!

@jeffladiray jeffladiray requested a review from slimee August 25, 2021 10:20
slimee
slimee approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@slimee slimee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jeffladiray jeffladiray merged commit 649f802 into master Aug 25, 2021
@jeffladiray jeffladiray deleted the fix/ignore-stats-models-dumper branch August 25, 2021 12:46
forest-bot added a commit that referenced this pull request Aug 25, 2021
@forest-bot
chore(release): 2.2.8 [skip ci]
fd5e6dd 
## [2.2.8](v2.2.7...v2.2.8) (2021-08-25)

### Bug Fixes

* **dumper:** ignore stats model name when generating/updating project to avoid route conflicts ([#216](#216)) ([649f802](649f802))
@forest-bot
Copy link
Member

🎉 This PR is included in version 2.2.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimee slimee slimee approved these changes

Assignees

@slimee slimee

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffladiray @forest-bot @slimee