Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spinner): fix cli lock on spinner pause #73

Merged
merged 2 commits into from
May 19, 2020
Merged

Conversation

larcin
Copy link
Contributor

@larcin larcin commented May 19, 2020

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • No automatic tests failures
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@larcin larcin requested a review from adriguy May 19, 2020 09:30
Copy link
Contributor

@adriguy adriguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice fix 🤘

@adriguy adriguy assigned larcin and unassigned adriguy May 19, 2020
@larcin larcin merged commit d7bdad6 into master May 19, 2020
@larcin larcin deleted the fix/spinner-locs-cli branch May 19, 2020 14:12
forest-bot added a commit that referenced this pull request May 19, 2020
## [1.3.1](v1.3.0...v1.3.1) (2020-05-19)

### Bug Fixes

* **spinner:** fix cli lock on spinner pause ([#73](#73)) ([d7bdad6](d7bdad6))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants