Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spinner): avoid promise failures on paused spinner #75

Merged
merged 1 commit into from
May 20, 2020
Merged

fix(spinner): avoid promise failures on paused spinner #75

merged 1 commit into from
May 20, 2020

Conversation

larcin
Copy link
Contributor

@larcin larcin commented May 20, 2020

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • No automatic tests failures
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@larcin larcin requested a review from adriguy May 20, 2020 08:57
adriguy
adriguy approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@adriguy adriguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me!
Should you do the same in the then just above to prevent similar issue when trying to do a this.success() whereas the spinner is paused?

@adriguy adriguy assigned larcin and unassigned adriguy May 20, 2020
@larcin
Copy link
Contributor Author

larcin commented May 20, 2020

Good to me!
Should you do the same in the then just above to prevent similar issue when trying to do a this.success() whereas the spinner is paused?

I don't think so. This only allows us to handle errors thanks happen outside of the flow. Success are only intended to be used through a correct flow.

@larcin larcin merged commit bc11afe into master May 20, 2020
@larcin larcin deleted the fix/spinner-pause-fail branch May 20, 2020 12:09
forest-bot added a commit that referenced this pull request May 20, 2020
@forest-bot
chore(release): 1.3.2 [skip ci]
99945d4 
## [1.3.2](v1.3.1...v1.3.2) (2020-05-20)

### Bug Fixes

* **spinner:** avoid promise failures on paused spinner ([#75](#75)) ([bc11afe](bc11afe))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriguy adriguy adriguy approved these changes

Assignees

@larcin larcin

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larcin @forest-bot @adriguy