Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

Tunajs bypass property propType assigned as number #54

Open
aalises opened this issue May 30, 2018 · 0 comments
Open

Tunajs bypass property propType assigned as number #54

aalises opened this issue May 30, 2018 · 0 comments

Comments

@aalises
Copy link

aalises commented May 30, 2018

Hello!
Thanks for this amazing project 🎼 I have noted that in the effects file, the tunaJS bypass propTypes are set as propTypes.number. Shouldn't it be propTypes.bool?
Test file of the tunaJS library where the bypass properties are assigned as booleans

Should we change the proptypes of the bypass property to be boolean, from number? Also, It would be nice to implement the Phaser effect (I used it a lot). I can make a pull request adding the phaser effect and correcting the propTypes today, WDYT?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant