Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate: Remove webpack resolve.alias? #2

Open
2 tasks
ryan-roemer opened this issue Nov 2, 2019 · 0 comments
Open
2 tasks

Investigate: Remove webpack resolve.alias? #2

ryan-roemer opened this issue Nov 2, 2019 · 0 comments

Comments

@ryan-roemer
Copy link
Member

We have all our package.json:dependencies hard-coded as resolve.alias for our core webpack configuration to ensure:

  1. Needed deps are in the require resolution path (since CLI may be outside of this path); and,
  2. To make sure we only have one installed library for those offenders that have singleton state (react, react-dom, etc.)

Task

  • See if we can avoid doing this hard coding?
  • Check unintended consequences for continuing...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryan-roemer