Fix IE11 support and duplicate helpers by adding new Rollup config #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitten
changed the title
kitten
force-pushed
the
fix/rollup-build
branch
11 times, most recently
from
5e57439 to
ad6a72c
Compare
This reduces deduplication while microbundle sort their issues out.
I just can't make it work, so good bye
|
Merging this since this replaces Travis CI, which is now switched off 👍 Nothing critical has changed though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #273
Object.assignis transpiled away to guarantee IE11 compatibilityBefore we had some duplicate helpers from Bublé in our bundle. So this is replacing Microbundle with a custom config.
We do ultimately have a replacement for
Object.assignin our bundle, but that helps with IE11 compatibility, which is 💯Ultimately it seems that the gzipped size actually remains the same! 🎉