Fix ssrExchange's client-mode defaulting based on suspense-mode #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 5, 2019
JoviDeCroock
approved these changes
Aug 5, 2019
|
nice |
iamstarkov
reviewed
Aug 5, 2019
| mode on the client-side as well. | ||
|
|
||
| ```js | ||
| const ssrCache = ssrExchange({ isClient: !!process.browser }); |
There was a problem hiding this comment.
afaik, typeof window !== 'undefined' is better
There was a problem hiding this comment.
Yea, totally, process.browser is a "Webpack-ism" which is noted here but that's fine too. I'm just assuming that people will be able to decide themselves :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was impossible to use the
ssrExchangetogether withsuspensemode on the client-side, since thessrExchangeassumes that it's on the server, when thesuspensemode is turned on.This PR adds a separate
isClientoption tossrExchange, so it can be told whether it's running on the client-side manually.