You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Victory charts is incompatible with Yarn PnP due to out of spec imports.
For example, victory-voronoi-container imports react-fast-compare but it is not declared in victory-voronoi-containers package.json.
This currently works for other package managers due to how the node_modules folders just happen to be mounted, but this should be considered undefined behavior.
Reproduction
Install victory into a project with Yarn PnP enabled.
Description
I've opened a PR to fix this immediate issue, it would be nice if yarn PnP installs were added to any CI tests that are being done to catch these kinds of issues.
Thanks!
The text was updated successfully, but these errors were encountered:
The Problem
Victory charts is incompatible with Yarn PnP due to out of spec imports.
For example,
victory-voronoi-container
importsreact-fast-compare
but it is not declared invictory-voronoi-container
s package.json.This currently works for other package managers due to how the node_modules folders just happen to be mounted, but this should be considered undefined behavior.
Reproduction
Install victory into a project with Yarn PnP enabled.
Description
I've opened a PR to fix this immediate issue, it would be nice if yarn PnP installs were added to any CI tests that are being done to catch these kinds of issues.
Thanks!
The text was updated successfully, but these errors were encountered: