BrushContainer doesn't work properly with scale='time'

[Zegoverno]

Bugs and Questions

Checklist

• This is not a victory-native specific issue. (Issues that only appear in victory-native should be opened here)

• I have read through the FAQ and Guides before asking a question

• I am using the latest version of Victory

• I've searched open issues to make sure I'm not opening a duplicate issue

The Problem

Describe the issue you're seeing, and what you expect the behavior to be.

Reproduction

Please try to reproduce the issue you're seeing in a sandbox. You can fork this sandbox to get started.

If you can't reproduce your issue in a sandbox, please create a minimal git repo that demonstrates the problem you're seeing. Include instructions for installing and reproducing your error.

Feature Requests

Checklist

• I've read through the Docs and Guides to make sure this functionality doesn't already exist

• I've searched open issues to make sure I'm not opening a duplicate issue

Description

Please describe the feature you're requesting in detail.

[Zegoverno]

I have a timeserie dataset and I tried to merge the Brush and Zoom example with the Zoom on Large Dataset.

The ZoomContainer works properly. But the BrushContainer returns a domain.x different from the ZoomContainer, the zoomcontainer returns the actual date but the brushcontainer returns the index of the data array, which broke the application.

My solution was to convert the date back to number, takeoff the scale='time' from the brushcontainer and apply the format this number back to date with tickformat.

For now it is working but I lose the nice feature that display from years to weekday when zooming.

[jim-r-martin]

I am seeing a similar issue where the domain for my chart no longer auto scales for the x domain (which is timestamps) as it did in 34.1.3 . The domain now scales from 0 to my largest timestamp, which skews all of my data to the far right of the graph. I think it has to do with the update released yesterday. I saw some commits that looked like they were impacting the domain but can't put my finger on which one it was.

[becca-bailey]

Closing in favor of #2111