Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enter / exit transitions for changing numbers of child components #246

Closed
boygirl opened this issue Apr 21, 2016 · 5 comments
Closed

enter / exit transitions for changing numbers of child components #246

boygirl opened this issue Apr 21, 2016 · 5 comments

Comments

@boygirl
Copy link
Contributor

boygirl commented Apr 21, 2016

transition code is expecting a child component at a particular index and not finding it since some filtering is happening. For this situation in data nodes for individual components we've added support for a key attr on data that will be used instead of index, but we don't currently have a similar concept for entire child components, so they are just referenced by index. It looks like there's a little bit more work to be done with changing numbers of child components.

@becca-bailey
Copy link
Contributor

@boygirl Do you know anything about the status of this one? It looks like #684 might have addressed this issue.

@boygirl
Copy link
Contributor Author

boygirl commented Nov 2, 2021

I think this issue is distinct from #684. This would refer to perhaps an entire new series of bars tansitioning in rather than an changing number of bars in a given series. Does the distinction make sense?

@becca-bailey
Copy link
Contributor

Oh okay, I see! I will leave it for now then.

@becca-bailey becca-bailey added this to the Refactor transitions milestone Nov 2, 2021
@becca-bailey
Copy link
Contributor

I'm going to close some of these specific transition issues for now in favor of opening a larger issue for a general overhaul of transition logic.

@becca-bailey
Copy link
Contributor

Larger issue thread: #2104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants