Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest [36.8.1] causing infinite test runs due to a max-depth issue in VictoryTransition #2708

Closed
wadehammes opened this issue Jan 10, 2024 · 6 comments
Assignees
Labels
Status: Needs More Info ✋ A question or report that needs more info to be addressable

Comments

@wadehammes
Copy link

Describe the bug
Latest has max-depth issues in when running in a test environment which is causing tests to run infinitely and not finish, all is well on 36.7.0

image

Victory version
Latest

Code Sandbox link
Please include a code sandbox link or a similar reproduction if possible.

To Reproduce

  • Run latest in a test env
@carbonrobot
Copy link
Contributor

Thanks for the note @wadehammes. Do you have some example test code I could run? Our test suite isn't picking this up, so it could be faster to find a solution with some samples.

@carbonrobot carbonrobot added the Status: Needs More Info ✋ A question or report that needs more info to be addressable label Jan 10, 2024
@carbonrobot carbonrobot self-assigned this Jan 10, 2024
@TomCorvus
Copy link

I have the same issue.
https://github.com/TomCorvus/RNChart

It appears when I try to update data prop of VictoryGroup component.
If I use VictoryLine and VictoryScatter only and I update their data prop, it's working.

@appa-gomi
Copy link

I have the same issue.

Downgrading to version 36.7.0 also does not work.

@TomCorvus
Copy link

@appa-gomi , you need to set version range to ~36.7.0, not ^36.7.0
And using resolutions (yarn) or overrides (npm) to avoid getting 36.8.X dependencies version.

  "resolutions": {
    "victory": "~36.7.0",
    "victory-area": "~36.7.0",
    "victory-axis": "~36.7.0",
    "victory-bar": "~36.7.0",
    "victory-box-plot": "~36.7.0",
    "victory-brush-container": "~36.7.0",
    "victory-brush-line": "~36.7.0",
    "victory-candlestick": "~36.7.0",
    "victory-chart": "~36.7.0",
    "victory-core": "~36.7.0",
    "victory-create-container": "~36.7.0",
    "victory-cursor-container": "~36.7.0",
    "victory-errorbar": "~36.7.0",
    "victory-group": "~36.7.0",
    "victory-histogram": "~36.7.0",
    "victory-legend": "~36.7.0",
    "victory-line": "~36.7.0",
    "victory-pie": "~36.7.0",
    "victory-polar-axis": "~36.7.0",
    "victory-scatter": "~36.7.0",
    "victory-selection-container": "~36.7.0",
    "victory-shared-events": "~36.7.0",
    "victory-stack": "~36.7.0",
    "victory-tooltip": "~36.7.0",
    "victory-voronoi": "~36.7.0",
    "victory-voronoi-container": "~36.7.0",
    "victory-zoom-container": "~36.7.0"
  },

@carbonrobot
Copy link
Contributor

We will have a fix released shortly today

@carbonrobot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs More Info ✋ A question or report that needs more info to be addressable
Projects
None yet
Development

No branches or pull requests

4 participants