Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VictoryGroup color propType to support function #732

Closed
Olliebaba opened this issue Aug 28, 2017 · 1 comment
Closed

VictoryGroup color propType to support function #732

Olliebaba opened this issue Aug 28, 2017 · 1 comment
Assignees
Labels
Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release

Comments

@Olliebaba
Copy link

Olliebaba commented Aug 28, 2017

I am building a chart which has multiple lines, scatter dots for each data point and a tooltip hover over for every scatter dot. I encountered 'z-indexing' issues where the tooltips were hidden behind other descendant siblings following the example in the gallery. (Change second data point of first Victory group to {x: 2, y: 0.5} then hover to see the overlap.) So I tried combining the data and making a single scatter group. The color prop on Victory group is applied to each scatter dot so I realized I could pass a function to dynamically set the color in the same way as VictoryScatter can take a function for size. This works perfectly but throws a propType error, that color must be a string. Can this prop's propTypes be switched to oneOf([string, func])?

@boygirl boygirl added the Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release label Sep 6, 2017
@boygirl
Copy link
Contributor

boygirl commented Sep 6, 2017

@Olliebaba sorry for the delay. I will make this change in an upcoming version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release
Projects
None yet
Development

No branches or pull requests

3 participants