-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug with icons of sort #9464
Comments
The label on the right side of the arrow is inverted, it is This design is based on glyphicons' one Leaving this open for discussion |
The arrow represents the reading order, from top to bottom, which is how we usually list items.
|
I thought about this too. Intuitively, I expected the arrows to flip. Right now, the symbols switch place, while the arrow stays pointing down. An alternative approach would be to let the symbols stay where they are, but flip the arrow instead. Example (including the proposed I think it I would prefer them to the type that is included now. |
Could you clarify what you mean? |
The meaning is the same for both: "As on top, Zs on bottom" The arrow indicates the direction of reading, but if I imagine those icons on the heading of a table, ⬆️ doesn't make sense, because I'm reading from the top to the bottom in both cases |
No need to agree with me. Just gave my opinion because the issue was left open for discussion. I would personally prefer the arrow to change direction, instead of the letters changing position. At the same time, this is not a priority change by any means, just a 'would be nice to have'. Edit: funnily enough, Microsoft's 'Custom sort' has the arrows pointing both ways :-) |
I'll put in my 2¢. I think the recent change to just switching the arrow is misleading. If you have a list or table, you're always reading top down, not bottom up, so to me the Excel way makes more sense. And the old way of doing ascending/descending, because to me it matches conceptually the idea "I want A at the top, Z at the bottom, or higher numbers at the top, lower numbers at the bottom." I struggle to understand how the arrow flipping is "intuitive." Especially if it breaks from a convention established by a ubiquitous piece of software. |
I recently upgraded from v4.7 and couldn't believe the change from |
@talbs could you please take a look? IMHO the point is valid. Apparently, glyphicons also changed their approach 🤔 |
@sensibleworld, what do you think? |
I just realized this is implemented differently for <p>FAS</p>
<i class="fas fa-fw fa-sort-amount-up"></i>
<i class="fas fa-fw fa-sort-amount-down"></i>
<p>FAB</p>
<i class="fab fa-fw fa-sort-amount-up"></i>
<i class="fab fa-fw fa-sort-amount-down"></i> Is this intentional? Is it documented somewhere? |
@totymedli That looks to be a glitch triggered by referencing |
We're finding a lot of clients are having issues with the sorting ascending and descending icons in v5.x vs v4.x Version 4.x Version 5.x We're using up and down chevrons on our projects for now since it seems to be a common topic between our applications where the user is just clicking the icons until they get the result they expect to see with respect to the actual data instead of making an informed decision based on the icon. The clients appear to be okay with the chevrons based on ease of understanding, but they appear unrefined in the UI. |
I was able to tweak the svg using illustrator and replacing the path in the .js files with the new paths to make it look like the old way. I don't know how to fork this to submit a PR or something, but here's what I have for both var faSortAlphaUp = { prefix: 'fas', iconName: 'sort-alpha-up', icon: [448, 512, [], "f15e", "M187.3,395.31l-80,80a16,16,0,0,1-22.62,0l-80-80C-5.36,385.24,1.81,368,16,368H64V48A16,16,0,0,1,80,32h32a16,16,0,0,1,16,16V368h48C190.23,368,197.35,385.26,187.3,395.31Zm112.3,76A12,12,0,0,1,288.07,480H252.35A12,12,0,0,1,241,464.14l57.09-168A12,12,0,0,1,309.45,288H349a12,12,0,0,1,11.36,8.14l57.1,168A12,12,0,0,1,406.11,480H370.37a12,12,0,0,1-11.51-8.62l-8.3-28.3H307.69l-8.09,28.23Zm22.86-78.7h13.37l-6.6-22.94ZM335,167.93l67.45-95.7a11.94,11.94,0,0,0,2.19-6.91V44a12,12,0,0,0-12-12H267.67a12,12,0,0,0-12,12V72.93a12,12,0,0,0,12,12h56.46c-.73,1-1.49,2-2.27,3.13l-67.2,95.21a12,12,0,0,0-2.19,6.92V212a12,12,0,0,0,12,12H393.82a12,12,0,0,0,12-12V183.07a12,12,0,0,0-12-12H332.67c.74-1,1.5-2,2.28-3.14Z"] };
var faSortNumericUp = { prefix: 'fas', iconName: 'sort-numeric-up', icon: [448, 512, [], "f163", "M313.24,369.73l-19.45-20.79a12,12,0,0,1,.56-16.95l43.44-40.74A12,12,0,0,1,346,288h31.59a12,12,0,0,1,12,12V427.07h25.66a12,12,0,0,1,12,12V468a12,12,0,0,1-12,12H306.08a12,12,0,0,1-12-12V439.07a12,12,0,0,1,12-12h25.41V369.13c-7.25,6.58-14.21,4.92-18.25.6ZM286.13,96.41c0-32.65,23.86-67.36,68.09-67.36,38.25,0,79.43,28.87,79.43,92.23,0,51.28-32.24,105.77-92,105.77-17.83,0-30.54-3.55-38.55-6.78a12,12,0,0,1-6.92-14.7l9.24-29.48a12,12,0,0,1,15.47-7.72c13,4.61,27.87,5.28,38.1-4.13-38.74,5.07-72.87-25.36-72.87-67.83Zm92.27,19.34c0-22.29-15.3-36.51-25.83-36.51-8.65,0-13.17,8-13.17,15.84,0,5.66,1.82,24.16,25.17,24.16,10,0,13.38-2.15,13.74-2.73A2.31,2.31,0,0,0,378.4,115.75ZM176,368H128V48a16,16,0,0,0-16-16H80A16,16,0,0,0,64,48V368H16C1.81,368-5.37,385.24,4.7,395.31l80,80a16,16,0,0,0,22.62,0l80-80c10-10.05,2.92-27.31-11.32-27.31Z"] }; Here's how they look in an app I'm working on. I hope this helps someone. |
@dually8 Thanks! Hoping to get this updated in the next release. |
The icons:
Have a bug in my opinion, they should have the arrow UP, not down, as the -DESC icons.
The text was updated successfully, but these errors were encountered: