Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Rejecting all binaries that include Font Awesome with error ITMS-90853: Invalid font #174

Closed
RayHughes opened this issue Sep 12, 2024 · 5 comments

Comments

@RayHughes
Copy link

RayHughes commented Sep 12, 2024

Describe the bug
This week Apple started rejecting all submitted builds that include Font Awesome as an invalid binary. This is affecting every iOS app that uses Font Awesome.

ITMS-90853: Invalid font - There was an error validating the font named 'FontAwesome6Free-Solid' at 'project.name/FontAwesome6_Solid.ttf'. ‘glyf’ table instructions.

Reproducible test case
The issue occurs when a binary is submitted for App Store review.

Expected behavior
App is not rejected upon submission to App Store review

Desktop (please complete the following information):

N/A

Additional context
This is likely related to the iOS 18 Font Menu and changes around it. This worked fine up until Monday when Apple announced the iPhone 16

Related Issue in different project: oblador/react-native-vector-icons#1658

Packages
"@fortawesome/fontawesome-free": "^6.6.0",
"@fortawesome/fontawesome-pro": "^6.6.0",
"@fortawesome/fontawesome-svg-core": "^6.6.0",
"@fortawesome/free-brands-svg-icons": "^6.6.0",
"@fortawesome/free-solid-svg-icons": "^6.6.0",
"@fortawesome/pro-duotone-svg-icons": "^6.6.0",
"@fortawesome/pro-light-svg-icons": "^6.6.0",
"@fortawesome/pro-regular-svg-icons": "^6.6.0",
"@fortawesome/pro-solid-svg-icons": "^6.6.0",
"@fortawesome/react-fontawesome": "^0.2.2",
"@fortawesome/react-native-fontawesome": "^0.3.2",

@RayHughes RayHughes changed the title Emergency: Apple Rejecting all binaries that include Font Awesome with error ITMS-90853: Invalid font Apple Rejecting all binaries that include Font Awesome with error ITMS-90853: Invalid font Sep 12, 2024
@robmadole
Copy link
Member

@RayHughes can you tell me how you are using this file? The react-native-fontawesome repo doesn't utilize it.

@RayHughes
Copy link
Author

@robmadole we are not using it at all. We are using standard FA usage.

@robmadole
Copy link
Member

You might try removing @fortawesome/fontawesome-free and @fortawesome/fontawesome-pro. I'm not sure how that TTF file is even being picked up. Has it been added as an asset to your project?

@RayHughes
Copy link
Author

RayHughes commented Sep 12, 2024

We just went through our dependency tree and found another library https://github.com/callstack/react-native-paper using FA. We removed the library and builds seem to be working as desired.

The error was so vague with Apple and worked 1+ years so we didn't know where to look. Sorry for the report.

@robmadole
Copy link
Member

No worries! Glad you got if fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants