Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup code with correct usage of $err and errmsg #120

Open
apkar opened this issue Mar 19, 2019 · 1 comment · May be fixed by #207
Open

Cleanup code with correct usage of $err and errmsg #120

apkar opened this issue Mar 19, 2019 · 1 comment · May be fixed by #207
Assignees
@senthil-db-expert
Labels
cleanup Code or design cleanup compatibility Either missing or incompatible features causing driver or tool compatibility
Milestone
2.0.0

Comments

@apkar
Copy link
Contributor

apkar commented Mar 19, 2019

Mongo has $err and errmsg in response from the server. Usually, $err is for the error code and errmsg is for error description. Our error handling is not consistent. At least it is less consistent than Mongo.
@hgray1 hgray1 added compatibility Either missing or incompatible features causing driver or tool compatibility cleanup Code or design cleanup labels Mar 19, 2019
@apkar apkar added this to the 1.8.0 milestone Mar 25, 2019
@apkar apkar modified the milestones: 1.8.0, 2.0.0 Aug 12, 2019
@senthil-db-expert
Copy link

@apkar please assign this to me.
Will cleanup and make them uniform using seterror function

drkannan added a commit to drkannan/fdb-document-layer that referenced this issue Aug 23, 2019
@drkannan
Resolves FoundationDB#120: Cleaned code to use generic function for r…
74b79e6 
…eporting error messages
@drkannan drkannan linked a pull request Aug 23, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@senthil-db-expert senthil-db-expert

Labels
cleanup Code or design cleanup compatibility Either missing or incompatible features causing driver or tool compatibility
Projects
None yet
Milestone
2.0.0
3 participants
@apkar @hgray1 @senthil-db-expert