Remove the requirement for marking GDTaskPlayerLoopAutoload as autoload #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this gets accepted, should we rename the |
|
This may also allow us to ship the addon as a plain managed class library through NuGet, which is more consistent with typical C# workflow. |
felipemullen
approved these changes
Nov 9, 2023
|
@Delsin-Yu hey thanks for the PR! I've been busy with university work for the past few months so I haven't had the chance to look over your PR. I'll be sure to review it this weekend. Thanks again for your help :) |
|
This looks good to merge. Thanks for your contribution! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the GDTaskPlayerLoopAutoload to self-initialize when any GDTask API is called, removing the requirement for adding it as an autoload. For backward compatibility reasons, users may still add this script to the autoload list and let the engine load it instead.