feat(db): Add command_meta and settings from argparser as json #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpelsepp
reviewed
Feb 24, 2023
src/gallia/db/handler.py
Outdated
| @@ -27,7 +27,7 @@ def bytes_repr(data: bytes) -> str: | |||
| return bytes_repr_(data, False, None) | |||
|
|
|||
|
|
|||
| schema_version = "1.0" | |||
| schema_version = "1.1" | |||
There was a problem hiding this comment.
Let's use schema 2. Major/Minor schemas do not make sense IMO.
rumpelsepp
reviewed
Feb 24, 2023
src/gallia/utils.py
Outdated
| def dump_args(args: Namespace) -> dict[str, str | int | float]: | ||
| settings = {} | ||
| for key, value in args.__dict__.items(): | ||
| if isinstance(value, str): |
peckto
force-pushed
the
db-meta-command
branch
3 times, most recently
from
65776f4
to
6e752d0
Compare
peckto
force-pushed
the
db-meta-command
branch
from
6e752d0
to
04cb4bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two columns to the
run_metadb table:command_meta: same as the one inMETA.jsonsettings: key -> value pair of settings retrieved from the argparserFor settings from the argparser, only the follwing trivial types are currently supported:
str,int,float.Other, complex data types would need a custom json serializer, which is out of scope for now.
Unsupported data types are skipped to prevent any confusion.
The DB schema version is increased to
2.0