Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOC Anchors are broken #22

Closed
vortexing opened this issue May 30, 2018 · 6 comments
Closed

TOC Anchors are broken #22

vortexing opened this issue May 30, 2018 · 6 comments
Labels
low priority Currently low priority things to come back to later web-styling Site appearance, search features, site structural changes or edits.

Comments

@vortexing
Copy link
Collaborator

Here is something I found about this theme regarding broken anchors. I don't know enough to know how to fix it though.
mmistakes/minimal-mistakes#1302
@vortexing vortexing added the web-styling Site appearance, search features, site structural changes or edits. label Jul 13, 2018
@dtenenba
Copy link
Contributor

dtenenba commented Aug 2, 2018

@vortexing Do you want me to try and implement the solution described at mmistakes/minimal-mistakes#1302 (comment) ?

@vortexing
Copy link
Collaborator Author

If you feel like it wouldn't be a huge time suck and might work, then sure. I know that I do not have the ability to do this, thus I will leave it up to you. I figure if it breaks things we can just revert the commit but we can't get your time back.

LMK what you decide though!

@dtenenba
Copy link
Contributor

dtenenba commented Aug 2, 2018

OK, I don't have time at the moment, but it bugs me. Really they should fix it upstream. But if I decide to work on this I will let you know.

@vortexing
Copy link
Collaborator Author

Sounds like a plan. This undertaking is a sizeable time suck as it is, so drawing the line somewhere is important.

@vortexing vortexing added the low priority Currently low priority things to come back to later label Dec 6, 2018
@atombaby
Copy link
Contributor

atombaby commented Mar 7, 2019

This was apparently fixed in 4.15.0

@atombaby
Copy link
Contributor

atombaby commented Mar 7, 2019

verified working

@atombaby atombaby closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority Currently low priority things to come back to later web-styling Site appearance, search features, site structural changes or edits.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atombaby @dtenenba @vortexing