Support AMD / RequireJS

[niutech]

I can read that you support CommonJS modules, but what about AMD / RequireJS? Could you transform them as well? Example: knockout-jqautocomplete.

[FredKSchott]

Any interest in helping us try something out? :)

The tool was built for ESM top-level dependencies, with a goal of supporting any CommonJS/AMD/RequireJS transitive/sub- dependencies. So if this is a sub-dependency of your project, it should just work.

If you want to rely on this non-ESM file directly, you just have to add the exact file path to your whitelist. Something like:

"whitelist": [ "knockout-jqautocomplete/build/knockout-jqAutocomplete.js"]

Can you try that out and let me know how it works? AMD/UMD were never meant to be supported, but because they have no import statements to worry about I think that we get their support for free.

[jarrodek]

I tried adding this:

"whitelist": [
      "marked/index.js",
      "@polymer/marked-element/marked-import.js"
]

but it makes no difference.

[FredKSchott]

can you share your entire package.json? I want to be sure that you're properly defining it (you can check the README) to be sure. If you have properly configured it, at the very least @pika/web should fail, and not ignore it.

[jarrodek]

Sure, it's here: https://github.com/advanced-rest-client/arc-electron/blob/develop/package.json#L269

Also, my comment was supposed to be added to this issue: PolymerElements/marked-element#100
I had too many tabs opened...

[pika-ci]

🚚 This issue has been moved! Continue the discussion on our project discussion board:
https://pika.dev/packages/@pika/web/discuss/1084