Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark video as watched, option #357

Closed
grrrrr opened this issue Aug 21, 2019 · 6 comments
Closed

Mark video as watched, option #357

grrrrr opened this issue Aug 21, 2019 · 6 comments
Labels
enhancement New feature or request Rewrite: featurerequest A feature request that is still valid for the rewrite

Comments

@grrrrr
Copy link

grrrrr commented Aug 21, 2019

in #180 I asked and received an option to be able to mark a video as not watched.

Would be be possible to get the ability to mark a video as watched as well? For my use case, I tend to watch youtube videos in a number of different ways (newpipe, freetube, youtube-dl,...) but use FreeTube as a way to organize the channels watch which means that not always can I have the luxury of having videos in FreeTube automatically marked as watched.

Instead if I look at a video outside of FreeTube, the next time I run it I have to go in and click on each video I watched elsewhere. This can be a bit laborious as it's a multi click ordeal

  • open freetube
  • load subscriptions
  • click on video to have it marked as watched
  • click on subscription to get back to list of videos
  • scroll to next watched video
  • repeat.

Proposed solution.

Currently in subscription or channel view, viewed videos have a menu item to "Remove from History". If would be useful if when a video is not watched, the menu item allows to "Add to history" or "Mark as watched"

@morfikov
Copy link

morfikov commented Aug 21, 2019

I think the design here isn't really well thought out. For instance, I have several favorite videos in the Favorites tab. All of them are marked as watched and grayed out. I don't think the fav videos should be marked in this way because it is known they were watched -- that's why you marked them as favorite. But now, you have all those favs marked as watched (that's not a big deal) and grayed out (this is a little bit annoying).

Also, when you hit the 3 dots near one of the fav vid, you get an option remove from history, and in my opinion this option should be limited to the History tab only.

Anyways, having mark as watched and mark as unwatched is a good idea.

@PrestonN
Copy link
Member

I think the design here isn't really well thought out. For instance, I have several favorite videos in the Favorites tab. All of them are marked as watched and grayed out. I don't think the fav videos should be marked in this way because it is known they were watched -- that's why you marked them as favorite. But now, you have all those favs marked as watched (that's not a big deal) and grayed out (this is a little bit annoying).

The favorites tab is also used as a "Watch Later" functionality. So it isn't guaranteed that the video in question has been watched already, which is why the overlay is shown.

Also, when you hit the 3 dots near one of the fav vid, you get an option remove from history, and in my opinion this option should be limited to the History tab only. It's weird because there's no corresponding option to remove favorite videos. To be hones I don't know how to remove favs. :D

You can remove them by clicking on the same button that you did to favorite it in the first place, regardless if this was while watching the video or not.

Either way, I agree that a "Add to Watch History" should be included. I will add this to a future release.

@PrestonN PrestonN added the enhancement New feature or request label Aug 21, 2019
@morfikov
Copy link

You can remove them by clicking on the same button that you did to favorite it in the first place, regardless if this was while watching the video or not.

I found it, but the button doesn't really contrast well with black background -- I simply missed it. An ordinary red X button would be a way better. :)

@felixsanz
Copy link

felixsanz commented Aug 12, 2020

@PrestonN Progress? Can we have an option on the 3 dots menu that says: "Mark as watched"¿ since i also use newpipe and other things and i want to mark videos as watched without doing all the above steps. this option is really really easy to implement.

Something like:

<div v-if='!video.watched'>
  <li v-on:click='history(video.id)' onclick='addToHistory(this.parentNode.parentNode.previousSibling);'>Add to History</li>
</div>

@PrestonN
Copy link
Member

At this point, the functionality will be saved for something to be included in the rewrite as that is my current focus. It will be included along with the initial implementation of history over there. For now I have no interest in adding any new features into the current code base as any time spent on it is time better spent on getting the rewrite up to parity. It's still on my list of things to do but may take a while before I can get to it.

@GilgusMaximus GilgusMaximus added the Rewrite: featurerequest A feature request that is still valid for the rewrite label Sep 30, 2020
@PrestonN
Copy link
Member

PrestonN commented Oct 1, 2020

This is included in the rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Rewrite: featurerequest A feature request that is still valid for the rewrite
Projects
None yet
Development

No branches or pull requests

5 participants