-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Inline user playlists in sidebar on desktop view #4594
Comments
I would like to add two things onto this:
|
I'd like to try this one. |
@Skidout before you go at it. Please answer the major questions in the issue because discussion about that is still needed. If you answered those the team can check if that aligns with us |
|
I would like to hold this off until we have released v0.20.0 |
Ok, Understood. |
@Skidout v0.20.0 has been released. Are you still interested in taking this one on? |
Yes. Have they decided on the major questions? |
I'll invite the other teammates to discuss. CC: @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @PikachuEXE @MarmadileManteater The main concerns I'm thinking about:
Because of the above, I disagree with any implementation that adds an additional control to bookmark playlists specifically for this purpose, especially given that we already have "quick bookmarks" available for a different purpose altogether. To revisit the implementation questions now, here are my recommended answers:
This is my personal recommendation, but I'm also fine with @absidue's recommendation of this as an alterative to 2/3:
With only the minor quibble that we should use the Let's get at least a couple of other FT contributor voices on this, but I think either of the above options would be fine. |
I'm hoping pinning a playlist to the top of this list of playlists (or potentially as a separate button as per #4861) would be possible. The benefit is immediate access to a commonly viewed playlist. However:
This would mostly solve it. The goal for me is for my "watch it later" playlist to be at most one click away. The only small issue which remains with the inline list suggestion is that you still must hunt for the playlist out of the limited set displayed as it may not be in the same position each time on screen (due to which playlists have been recently modified). This is why I initially wanted to pin a single playlist as a button, i.e. essentially the pre-v0.20 "Saved Videos" button. |
I agree with everything that is mentioned by @jasonhenriquez and @absidue. I have nothing to add. |
Maybe the quick bookmark target should still be shown in compact mode, that way people using compact mode can use the new feature. There wouldn't be any problems with identifying it since the user chooses the playlist manually. @absidue's suggestion for 2/3 seems like the better suggestion since the difference between a show more button & the playlists tab button would be very little if only the quick bookmark target is shown at first, but the playlists tab would let you sort & search while the sidebar would let you navigate through playlists without navigating away from the current page or opening a new window. However, the sorting order should follow the one the 'UserPlaylists/sortBy' value. |
Sounds good to me @Skidout! |
Would you like me to set you as the assignee on this one? @Skidout |
Yea that would be good. |
Everything is going pretty well, just need to add the 'show more' button & do some testing. Only thing I'm not sure about is what icons to use. Right now I've left the playlists tab icon as 'fas bookmark', the quick bookmark playlist is 'fas heart', & the other playlists as 'fas list'. I'm thinking that 'fas bars would work well for the playlists tab, then it would make sense to change the quick bookmark playlist to 'fas bookmark', & I feel like there might be something better than 'fas bars' for the other playlists. I'd like some input on what you guys think would be good. |
I wouldn't use Using it for other playlists is okay though, because if you are implementing it as discussed above, then they won't be visible when the side bar is collapsed, so there would be no issue, as the only times those icons would be visible is when they have a label next to them. |
Great work @Skidout! Feedback: I can see that the heart is being used to represent the Quick Bookmark playlist, but I don't think that indicator is needed, at least so prominently, as it seems to visually suggest that it's of a whole separate category/type than the others, which is an overstatement. I'd prefer either making it use the same icon as the others or putting a very small heart by or inside the same icon (decently harder request, fine if not feasible). |
@absidue I meant 'fas bookmark', not 'fas bars', sorry. |
@jasonhenriquez I'll see if I can put the heart icon alongside the bars. If not, I'll use 'fas bars'. What do you guys think about using 'fas table-list' for the playlists tab since it's for all the playlists & not just saved videos anymore. |
It looks too similar to the Channels tab IMO ( |
Hi @Skidout could you provide a status update |
Still working on it, been busy with appointments. |
Guidelines
Problem Description
The flow of accessing favorites is more jarring for desktop view with the inclusion of user playlists, now having to click the Playlist tab, wait for the
/userPlaylists
route to load, then click my desired playlist to get where I want to be. It would be desirable if I didn't have to do two actions to access my playlist of choice (as was the case before).Proposed Solution
Inline the user playlists in the side nav for the desktop view, much like the YT implementation. This makes this for a more streamlined UX flow that matches how I used it before.
One major question is what we do with the Playlists tab on the desktop view. I say hide it because it then no longer serves a real purpose other than easy access to the "Create New Playlist" button. We can probably add an "Add New Playlist" button as a sidenav option to compensate.
Another major question is if we add a "Show more" / "Show less" button like YT. I say yes to this as well, because users might have a significant number of playlists.
A third major question is if we show a playlist that exists outside of the "Show more". Yes: the quick bookmark target.
Nothing should be changed at all on the mobile view.
Alternatives Considered
Issue Labels
ease of use improvement, improvement to existing feature
Additional Information
No response
The text was updated successfully, but these errors were encountered: