Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Region for Trending (Profile Level instead of General Settings) #484

Closed
p2635 opened this issue May 25, 2020 · 9 comments
Closed
Labels
enhancement New feature or request Rewrite: featurerequest A feature request that is still valid for the rewrite U: duplicate This issue or pull request already exists

Comments

@p2635
Copy link

p2635 commented May 25, 2020

Hi I'm a new user of FreeTube and I'm quite enjoying it, thanks for the hard work.

As I understand, the region for trending is done as general settings instead of the profile level. Would it be possible for that to be implemented as a future enhancement?

Related: #14

@GilgusMaximus GilgusMaximus added the Rewrite: featurerequest A feature request that is still valid for the rewrite label Oct 1, 2020
@PrestonN
Copy link
Member

PrestonN commented Oct 1, 2020

Region will soon be based on your IP (because of a new API) so this might not be possible any more. So I will be closing this for now.

@PrestonN PrestonN closed this as completed Oct 1, 2020
@GilgusMaximus
Copy link
Contributor

YouTube still allows to set the region. I also added the option to choose to the trending module. Just the country code has to come from FreeTube as well as a setting to change it

@GilgusMaximus GilgusMaximus reopened this Oct 14, 2020
@GilgusMaximus GilgusMaximus mentioned this issue Oct 22, 2020
2 tasks
@efb4f5ff-1298-471a-8973-3d47447115dc

YouTube still allows to set the region. I also added the option to choose to the trending module. Just the country code has to come from FreeTube as well as a setting to change it

I wanted to set another region for trending but i cant select anything is this a known bug?

BrbvMKmycr.mp4

@peepo5
Copy link
Contributor

peepo5 commented Sep 27, 2021

@efb4f5ff-1298-471a-8973-3d47447115dc try changing locale and reversing and try again

@kommunarr
Copy link
Collaborator

Region will soon be based on your IP (because of a new API) so this might not be possible any more.

Was this behavior ever implemented?

@efb4f5ff-1298-471a-8973-3d47447115dc

Nope, just checked with my VPN.

@PrestonN
Copy link
Member

@jasonhenriquez

I believe my wording with that was that at the time only the Invidious API was available.

I believed that the local API would automatically grab trending based on your region since grabbing that information would be based on the user IP instead of the server IP.

If it isn't behaving this way, we'll need to look into what's going on, as this should be implemented via the settings page already.

@kommunarr
Copy link
Collaborator

@PrestonN Ah okay, yes, the main issue is the base case of using the app without ever manually setting a locale preference leaves the Region for Trending dropdown unusable.

@efb4f5ff-1298-471a-8973-3d47447115dc

Duplicate of #1996

@github-actions github-actions bot added the U: duplicate This issue or pull request already exists label Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Rewrite: featurerequest A feature request that is still valid for the rewrite U: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

6 participants