Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Playlist action icon accessibility issues #4940

Closed
6 tasks done
kommunarr opened this issue Apr 13, 2024 · 3 comments · Fixed by #4943
Closed
6 tasks done

[Bug]: Playlist action icon accessibility issues #4940

kommunarr opened this issue Apr 13, 2024 · 3 comments · Fixed by #4943
Assignees
Labels
B: accessibility B: usability bug Something isn't working good first issue Good for newcomers

Comments

@kommunarr
Copy link
Collaborator

kommunarr commented Apr 13, 2024

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have encountered this bug in the official downloads of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

  1. Open a video inside of a playlist and hit the Shuffle, Loop, Reverse, or Pause button.
  • See that color is the only thing indicating whether the control is active or not. This makes color the only way to distinguish between these states of activity, thus introducing the inaccessibility anti-pattern of color dependence.
  • See that aria-pressed is not set to true.

Screenshot_20240412_190412

Expected Behavior

  • Add a separate visual indication to the control when it is active and/or inactive. Example from YT: the icon's font-weight increases.
  • Add aria-pressed: true when a toggle is active.

Screenshot_20240412_191818

Issue Labels

accessibility issue, usability issue

FreeTube Version

v0.20.0

Operating System Version

OpenSUSE TW

Installation Method

.zip

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

@kommunarr kommunarr added the bug Something isn't working label Apr 13, 2024
@kommunarr kommunarr added the good first issue Good for newcomers label Apr 13, 2024
@sossost
Copy link
Contributor

sossost commented Apr 13, 2024

hi. @jasonhenriquez I am sossost, a new contributor. Can I fix this? thank you

@efb4f5ff-1298-471a-8973-3d47447115dc

@sossost go for it :)

@sossost
Copy link
Contributor

sossost commented Apr 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: accessibility B: usability bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants