Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cursor no longer automatically hides alongside player controls #5838

Closed
6 tasks done
geominorai opened this issue Oct 7, 2024 · 8 comments · Fixed by #5939, #6090 or #6135
Closed
6 tasks done

[Bug]: Cursor no longer automatically hides alongside player controls #5838

geominorai opened this issue Oct 7, 2024 · 8 comments · Fixed by #5939, #6090 or #6135
Labels
B: feature stopped working B: usability B: visual bug Something isn't working third-party Related to third-party logic

Comments

@geominorai
Copy link

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have encountered this bug in the official downloads of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

Following the switch to Shaka Player, the mouse cursor no longer hides itself while inside the video player region (or while in full screen mode) when the video controls automatically hide during playback.

Expected Behavior

Cursor should auto hide when the player controls hide if inside the video player region.

Issue Labels

feature stopped working, usability issue, visual bug

FreeTube Version

v0.21.3-nightly-4852

Operating System Version

Windows 10 build 19045.4780 (22H2)

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

v0.21.3

Additional Information

This may be a focus-related bug as the cursor auto hides properly during playback after clicking in the dark shaded area far under the video player seek bar. This remains working as long as the cursor is within the video player region or directly underneath it (i.e. the video description and comment section). As soon as the cursor moves outside this area (i.e. the subscription list on the left, the Up Next video list on the right, or the top bar with the app logo and search bar), the bug returns and the cursor no longer auto hides when moved back inside the video player region during playback.

Nightly Build

@OothecaPickle
Copy link
Contributor

related to shaka-project/shaka-player#7394

@efb4f5ff-1298-471a-8973-3d47447115dc

Other steps to reproduce

watch video -> press f to go fullscreen -> see that cursor never disappears -> press f -> click on fullscreen button -> see that cursor disappears

Could also be related to #4137

@absidue absidue added the third-party Related to third-party logic label Oct 7, 2024
@RickyM7
Copy link

RickyM7 commented Oct 25, 2024

Apparently this has now been fixed (shaka-project/shaka-player#7464). The latest releases of shaka has this fix.

@geominorai
Copy link
Author

geominorai commented Oct 28, 2024

This appears to have fixed the issue in the general case, thanks!

Unfortunately, I have found two scenarios where the cursor still does not auto-hide:

  1. The cursor will not hide if it is within the video player area before the video player finishes loading in. This happens even if autoplay videos is disabled, as long as clicking to start the video does not move the cursor position. This scenario happens often when opening videos from the playlist and subscription pages, since many items there are positioned within the video player area. Simply clicking to open the video and letting go of the mouse would trigger this bug.

  2. The cursor will stay as the pointing finger icon and not hide if it is over the seek bar as the seek bar auto hides (and surprisingly, clicking while this happens skips to the corresponding video timestamp as if the seek bar were still there, which is unexpected).

@efb4f5ff-1298-471a-8973-3d47447115dc

@geominorai
Copy link
Author

geominorai commented Nov 3, 2024

@efb4f5ff-1298-471a-8973-3d47447115dc I can reliably reproduce both cases:

Case 1 was reproduced on a freshly opened page on https://nightly-dot-shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;panel=ALL_CONTENT;build=uncompiled where clicking on a video example lets the auto page scroll upwards end with the cursor on top of the video player area, which starts playing and hides the seek bar but not the cursor. It is not quite the same as on FreeTube where the page does not have to scroll after selecting the video, however.

Case 2 can be reproduced on any player.

@efb4f5ff-1298-471a-8973-3d47447115dc

@geominorai best to comment this upstream on shaka-project/shaka-player#7394

@geominorai
Copy link
Author

Unfortunately, it looks like #6090 did not fix the two cases mentioned above either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment