-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeTube Doesn't Register it's Protocol Correctly on Mac #618
Comments
Hi. Thanks that you identified the situations so closely.
I think overall these are some good first issues for new contributors. In regards to the contribution guideline take a look here #566. I hope we can add it back soon |
Thank you for the quick response! :) 1.2. Exactly what I imagined ;) I'm your "Mac tester" then! ;) PS |
So in the next release, or if you want to use the automated releases that are under the actions tab, the plugin is already fixed. |
I'm sorry, I went to Actions but I don't understand what I should do... 🤔 |
If you follow this link and click on the first build, you'll see downloadable binaries for your device. Assuming FreeTube is installed on your machine, it should enable the This is already working and enabled in the latest dev builds, so I'll go ahead and close this issue. |
Each commit message you see is a new build. For example, the first build in that picture is the build with the message "Update README.md" Click on that and you'll find the download links. |
That sounds like a different issue. I'd need to know what video you're trying to open that's causing that error. If FreeTube is opening properly, then it's not a problem with the extension and needs to be a new issue. |
Actually is the same error I put in my first message, but you're right it's something else: I get that error every time I open the App! I mistakenly associated the error with the video opening, but they are probably not correlated. The behaviour I see when I click on a YT link (whatever) is:
This still needs to be fixed, so please re-open the issue. 🙏 |
I found the real cause of the "TypeError: Cannot read property 'simpleText' of undefined" error and opened another issue: #622 |
I tried to open freetube://www.youtube.com/watch?v=WHATEVER, I get the request to choose the FreeTube app but the behaviour is the same described: app opens or gets in focus but no video loaded. |
Can you confirm that when FreeTube automatically opens up that it's using v0.9.0? If I had to guess, your Mac might still be using v0.8.0 to open the link, which wouldn't have the logic in it. |
Alright. This is starting to be strange. If you have the app opened up before you click on a link, does it redirect properly? I'm curious if it's maybe a timing issue with how the app is setup. If this works then this should help narrow it down. |
No, in no case the video is loaded, the app just opens or switch focus but nothing else. 😢 It loads the default view with recent videos. |
Same case for me as well, on macOS. |
Going to re-purpose this issue since there's still a problem going on. Please know that I don't have access to a Mac and it's much harder for me to test for one, so this may be a while before I can get a proper look at it. |
Could one of you please try out this build and see if this fixes the issue? I haven't tested this so it might not work, but after some reading up the change I made should have done something. Let me know if anything is different. |
It looks the same behaviour to me 😞 Maybe you can make a build with some debugging output that I can send you back to analyse? |
Also have the same problem with the latest build (the latest build includes all commits correct?). |
I've implemented a fix for this in the linked PR. The custom protocol handling in macOS is different to Win/Linux. Those flows also changed a bit but I don't have a Win/Linux machine to test them on, so if someone could do a sanity check on those too that would be much appreciated. |
waiting the build to test it! 😄 |
@cmf , can confirm that this works on my MBP 16". Good job! |
Since I love FreeTube very much, I would like to use it to open automagically YT links in any kind of situation. I use Mac OS but I think can be applied to Linux and Windows as well.
ANALYSIS
I can identify 3 kinds of "open a link" situations:
CHALLENGES/PROBLEMS
Any solution/fix?
Thank you! 🙏
The text was updated successfully, but these errors were encountered: