Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes CSS deduplication #2868

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Themes CSS deduplication #2868

merged 4 commits into from
Nov 15, 2022

Conversation

absidue
Copy link
Member

@absidue absidue commented Nov 14, 2022 •
edited
Loading

Themes CSS deduplication

Pull Request Type

  • Other - Cleanup

Description

Just deduplicates some of the CSS rules, that way the output is 6KB smaller. You probably want to review this commit by commit, instead of looking at it all in one go.

Screenshots

before
after

Testing

Check that the colours still work, you don't need to test all of them if you don't want to.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.18.0

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 14, 2022
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 14, 2022 20:09
@absidue absidue changed the title Themes css deduplication Themes CSS deduplication Nov 14, 2022
PikachuEXE
PikachuEXE approved these changes Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have tools to do this for us semi-auto/full-auto in the future?

@absidue
Copy link
Member Author

absidue commented Nov 15, 2022

I can try some of the other tools that the CssMinimizerPlugin supports, currently we are using cssnano which is the default.

@FreeTubeBot FreeTubeBot merged commit 9600373 into FreeTubeApp:development Nov 15, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 15, 2022
@absidue absidue deleted the themes-css-deduplication branch November 15, 2022 08:16
@PikachuEXE PikachuEXE mentioned this pull request Dec 14, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot