Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$this->Form->select() missing "form-select" class #369

Closed
1 of 3 tasks
umer936 opened this issue Apr 27, 2022 · 0 comments · Fixed by #373
Closed
1 of 3 tasks

$this->Form->select() missing "form-select" class #369

umer936 opened this issue Apr 27, 2022 · 0 comments · Fixed by #373

Comments

@umer936
Copy link
Contributor

umer936 commented Apr 27, 2022

This is a (multiple allowed):

  • bug

  • enhancement

  • feature-discussion (RFC)

  • BootstrapUI Version: 4.0.0.

  • Bootstrap Framework Version: 5.1.3

  • jQuery: N/A

  • Platform and Target: N/A (apache on Linux, Firefox web browser)

What you did

echo $this->Form->select('version', $versions);

Expected Behavior

It should have class="form-select" and look identical to

echo $this->Form->control('version', [
    'type' => 'select',
    'options' => $versions,
    'label' => false,
]);

Actual Behavior

The first version of the select is missing the "form-select" class and thus does not have the dropdown arrow expected of a select box.

image

Extra info

$options = $this->injectClasses('form-select', $options);
contains the line where form-select is added. It needs to also add in the case of $this->Form->select().
Commit where functionality was added: ea518ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant