Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow copying discussion url on ShareModal #30

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Allow copying discussion url on ShareModal #30

merged 3 commits into from
Dec 14, 2022

Conversation

datlechin
Copy link
Contributor

@datlechin datlechin commented Sep 1, 2022 •
edited
Loading

This PR has changes:

  • Reformat admin code
  • Add feature that allows users copy the discussion url directly on ShareModal

Before click to copy button
image

After click to copy button
image

@datlechin datlechin marked this pull request as draft September 1, 2022 15:59
@datlechin datlechin marked this pull request as ready for review September 1, 2022 16:09
imorland
imorland approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing this PR.

I'd prefer to see this under a setting toggle so that forum admins can decide if they want to display the copy or not, but I'll take care of that in a moment.

Thank you for your contribution!

@imorland imorland merged commit 32bdb30 into FriendsOfFlarum:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@datlechin @imorland