Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion links don't use custom slugger #24

Open
clarkwinkelmann opened this issue Sep 12, 2022 · 0 comments
Open

Discussion links don't use custom slugger #24

clarkwinkelmann opened this issue Sep 12, 2022 · 0 comments
Labels

Comments

@clarkwinkelmann
Copy link
Member

Bug Report

Current Behavior
All discussion links in mail templates are hard-coded to use discussion ID

'{discussion_url}' => $url->to('forum')->route('discussion', ['id' => $blueprint->discussion->id]),

'{post_url}' => $url->to('forum')->route('discussion', ['id' => $blueprint->post->discussion_id, 'near' => $blueprint->post->number]),

'{post_url}' => $url->to('forum')->route('discussion', ['id' => $blueprint->post->discussion_id, 'near' => $blueprint->post->number]),

'{post_url}' => $url->to('forum')->route('discussion', ['id' => $blueprint->post->discussion_id, 'near' => $blueprint->post->number]),

Expected Behavior
Should use slugger.

Environment

  • Extension version: observed on master branch during visual code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant