Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

random_compat 1.x not insecure if on patched PHP version? #259

Closed
andrerom opened this issue Feb 28, 2018 · 3 comments
Closed

random_compat 1.x not insecure if on patched PHP version? #259

andrerom opened this issue Feb 28, 2018 · 3 comments

Comments

@andrerom
Copy link

Not that it's so relevant anymore, but from the looks of it seems the version rule on random_compat might be a bit too strict, as the underlying lack of randomness with openssl issue seems to have been fixed in later version of PHP:
php/php-src@0e2447c

@fabpot
Copy link
Member

fabpot commented Feb 28, 2018

@andrerom If you think there is something to change, please submit a pull request. I'm mostly merging pull requests here, so any issue won't be fixed by "maintainers" of this repo :)

@andrerom
Copy link
Author

andrerom commented Mar 1, 2018

Posted the relevant question on paragonie/random_compat#96 (comment), based on feedback ew can sew if there is anything we could change here.

Solution could be a 1.5 which requires the relevant PHP versions which fixes this >=1.5 can be whitelisted.

@andrerom
Copy link
Author

andrerom commented Mar 2, 2018

Summary
Seems that the issue is solved in newer versions of PHP. So in other words this is false positive for anyone on newer PHP version. But nevertheless the standing recommendation from maintainer is to upgrade to random_compat 2.x to not rely on user land provided randomness.

As there does not seems to be a way to annotate that 1.x is only really vulnerable on PHP 5.6.23 and lower, I guess this can be closed as can't fix as long as there is no random_compat 1.x release requiring said PHP versions which fixes this.

@andrerom andrerom closed this as completed Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants