INFO: Not building on io.js 1.X; fix pending #93

19h · 2015-03-26T14:38:23Z

Hi,

just to inform people who are affected: the fix for the bad inlined uv_tty_set_mode is pending and awaits landing in io.js 1.6.2 (?) [-> https://github.com/libuv/libuv/pull/265/files]

Cheers

zachfeldman · 2015-04-27T04:19:00Z

@KenanSulayman so when will this be fixed? I now can't install on Mac OS X.

19h · 2015-04-27T05:53:38Z

It landed in libuv/libuv@252f362. What kind of issues are you dealing with?

zachfeldman · 2015-04-27T12:52:11Z

Here's the log with my issue (some paths edited for privacy). I'm using Node I believe but I had the same issue

$ npm install node-spotify
/
> node-spotify@0.7.1 install ~/spot/node_modules/node-spotify
> node-gyp rebuild

  COPY Release/spotify.js
  COPY Release/metadataUpdater.js
  CXX(target) Release/obj.target/nodespotify/src/node-spotify.o
  CC(target) Release/obj.target/nodespotify/src/audio/audio.o
  CXX(target) Release/obj.target/nodespotify/src/audio/AudioHandler.o
  CXX(target) Release/obj.target/nodespotify/src/audio/NodeAudioHandler.o
In file included from ../src/audio/NodeAudioHandler.cc:1:
In file included from ../src/audio/NodeAudioHandler.h:4:
In file included from ../src/audio/AudioHandler.h:5:
In file included from ../src/audio/audio.h:30:
/Users/defaultuser/.node-gyp/0.12.2/deps/uv/include/uv.h:649:12: error: conflicting types for 'uv_tty_set_mode'
inline int uv_tty_set_mode(uv_tty_t* handle, int mode) {
           ^
/Users/defaultuser/.node-gyp/0.12.2/deps/uv/include/uv.h:642:15: note: previous declaration is here
UV_EXTERN int uv_tty_set_mode(uv_tty_t*, uv_tty_mode_t mode);
              ^
1 error generated.
make: *** [Release/obj.target/nodespotify/src/audio/NodeAudioHandler.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:269:23)
gyp ERR! stack     at ChildProcess.emit (events.js:110:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1074:12)
gyp ERR! System Darwin 14.0.0
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/defaultuser/Dropbox/dev/alexa-spot/node_modules/node-spotify
gyp ERR! node -v v0.12.2
gyp ERR! node-gyp -v v1.0.3
gyp ERR! not ok
npm ERR! Darwin 14.0.0
npm ERR! argv "node" "/usr/local/bin/npm" "install" "node-spotify"
npm ERR! node v0.12.2
npm ERR! npm  v2.7.5
npm ERR! code ELIFECYCLE

npm ERR! node-spotify@0.7.1 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the node-spotify@0.7.1 install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the node-spotify package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls node-spotify
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!    ~/spot/npm-debug.log

19h · 2015-04-27T12:54:30Z

/Users/defaultuser/.node-gyp/0.12.2/

This fix landed in io.js. I don't know when you can expect this fix in node-legacy.

zachfeldman · 2015-04-27T13:07:13Z

So how would I install node spotify in io.js instead of node.js? I'm frankly a bit new to the ecosystem.

19h · 2015-04-27T13:55:15Z

If you fancy, you could use ny, a version manager by me.

$ npm install -g ny
$ ny 1.8.1

Should install iojs 1.8.1.

$ ny 0.12.2

Should install node 0.12.2.

$ npm install FrontierPsychiatrist/node-spotify

fspoettel · 2015-05-04T14:37:44Z

fwiw, the build is failing for me in iojs 1.8.1.

> node-spotify@0.7.1 install /Users/eineente/Github/moodify/node_modules/node-spotify
> node-gyp rebuild

  COPY Release/spotify.js
  COPY Release/metadataUpdater.js
  CXX(target) Release/obj.target/nodespotify/src/node-spotify.o
  CC(target) Release/obj.target/nodespotify/src/audio/audio.o
  CXX(target) Release/obj.target/nodespotify/src/audio/AudioHandler.o
  CXX(target) Release/obj.target/nodespotify/src/audio/NodeAudioHandler.o
In file included from ../src/audio/NodeAudioHandler.cc:1:
In file included from ../src/audio/NodeAudioHandler.h:4:
In file included from ../src/audio/AudioHandler.h:5:
In file included from ../src/audio/audio.h:30:
/Users/eineente/.node-gyp/1.8.1/deps/uv/include/uv.h:649:12: error: conflicting
      types for 'uv_tty_set_mode'
inline int uv_tty_set_mode(uv_tty_t* handle, int mode) {
           ^
/Users/eineente/.node-gyp/1.8.1/deps/uv/include/uv.h:642:15: note: previous
      declaration is here
UV_EXTERN int uv_tty_set_mode(uv_tty_t*, uv_tty_mode_t mode);
              ^
1 error generated.
make: *** [Release/obj.target/nodespotify/src/audio/NodeAudioHandler.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/eineente/.nvm/versions/io.js/v1.8.1/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:269:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:169:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1009:12)
gyp ERR! System Darwin 14.3.0
gyp ERR! command "/Users/eineente/.nvm/versions/io.js/v1.8.1/bin/iojs" "/Users/eineente/.nvm/versions/io.js/v1.8.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/eineente/Github/moodify/node_modules/node-spotify
gyp ERR! node -v v1.8.1
gyp ERR! node-gyp -v v1.0.3
gyp ERR! not ok 
npm ERR! Darwin 14.3.0
npm ERR! argv "/Users/eineente/.nvm/versions/io.js/v1.8.1/bin/iojs" "/Users/eineente/.nvm/versions/io.js/v1.8.1/bin/npm" "install" "FrontierPsychiatrist/node-spotify" "--save"
npm ERR! node v1.8.1
npm ERR! npm  v2.9.0
npm ERR! code ELIFECYCLE

npm ERR! node-spotify@0.7.1 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the node-spotify@0.7.1 install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the node-spotify package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls node-spotify
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/eineente/Github/moodify/npm-debug.log

19h · 2015-05-05T09:54:03Z

Indeed, I tested with the relevant libuv. Looks like nodejs/node@b2a0d8f didn't actually land all the changes (1.4.2 was tagged before the fix was landed). That is, you can manually fix it in the mean time by applying libuv/libuv@252f362 yourself into /Users/eineente/.node-gyp/1.8.1/deps/uv/include/uv.h:649 ff.

Fix awaits landing in libuv ~~1.4.3~~ 1.5.0 (iojs 1.8.2 or 2.0.0 (?)). See referenced issue below.

fspoettel · 2015-05-08T07:07:00Z

@KenanSulayman Works as of iojs 2.0.1 thanks for raising the issue with the devs, much appreciated!

19h · 2015-05-08T12:00:52Z

Sure 🍻

FrontierPsychiatrist · 2015-05-10T09:12:49Z

I just tried to compile on my new linux box with node 0.12.2 and got the same error.

19h · 2015-05-10T09:23:46Z

@FrontierPsychiatrist libuv 1.5.0 is far from landing in node 0.12; however, as outlined above, iojs 2.0.1 landed the fix.

FrontierPsychiatrist · 2015-05-10T09:25:17Z

That's just great, thanks for the heads up. I'll try io.js later.

FrontierPsychiatrist · 2016-06-05T12:49:12Z

Please recheck with 0.7.2 if this is still relevant.

19h · 2016-06-05T19:56:17Z

Can confirm that it builds with Node 6, thanks.

19h mentioned this issue May 5, 2015

Borked libuv 1.4.2 update nodejs/node#1621

Closed

FrontierPsychiatrist closed this as completed Jun 5, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

INFO: Not building on io.js 1.X; fix pending #93

INFO: Not building on io.js 1.X; fix pending #93

19h commented Mar 26, 2015

zachfeldman commented Apr 27, 2015

19h commented Apr 27, 2015

zachfeldman commented Apr 27, 2015

19h commented Apr 27, 2015

zachfeldman commented Apr 27, 2015

19h commented Apr 27, 2015

fspoettel commented May 4, 2015

19h commented May 5, 2015

fspoettel commented May 8, 2015

19h commented May 8, 2015

FrontierPsychiatrist commented May 10, 2015

19h commented May 10, 2015

FrontierPsychiatrist commented May 10, 2015

FrontierPsychiatrist commented Jun 5, 2016

19h commented Jun 5, 2016

INFO: Not building on io.js 1.X; fix pending #93

INFO: Not building on io.js 1.X; fix pending #93

Comments

19h commented Mar 26, 2015

zachfeldman commented Apr 27, 2015

19h commented Apr 27, 2015

zachfeldman commented Apr 27, 2015

19h commented Apr 27, 2015

zachfeldman commented Apr 27, 2015

19h commented Apr 27, 2015

fspoettel commented May 4, 2015

19h commented May 5, 2015

fspoettel commented May 8, 2015

19h commented May 8, 2015

FrontierPsychiatrist commented May 10, 2015

19h commented May 10, 2015

FrontierPsychiatrist commented May 10, 2015

FrontierPsychiatrist commented Jun 5, 2016

19h commented Jun 5, 2016