Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reapplying of the rollbacked blocks during the production of the blocks #1902

Closed
xgreenx opened this issue May 18, 2024 · 0 comments · Fixed by #2094
Closed

Support reapplying of the rollbacked blocks during the production of the blocks #1902

xgreenx opened this issue May 18, 2024 · 0 comments · Fixed by #2094
Assignees

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented May 18, 2024

Should be used with FuelLabs/fuel-utils#1

The block producer on start up will check if there are any predefined blocks that need to be produced first, then it will move to normal block production.

  • Teach the block producer of fuel-core to support the production of the blocks from a pre-defined list of blocks. The blocks should be produced one by one without delays since the time is already known, and the blocks are from the past. Pre-defined blocks should be passed as a CLI argument via the file. The format of the file should match with the format from the Develop transactions extractor fuel-utils#1. The tracking issue for this one is Support reapplying of the rollbacked blocks during the production of the blocks #1902
    • During production we need to track the list of discarded transactions from pre-defined blocks for the statistic to report later in the block post about reorg.
@xgreenx xgreenx changed the title Support recovering of the blocks during the production of the blocks Support recovering of the rollbacked blocks during the production of the blocks May 18, 2024
@xgreenx xgreenx self-assigned this Jun 10, 2024
@MitchTurner MitchTurner changed the title Support recovering of the rollbacked blocks during the production of the blocks Support reapplying of the rollbacked blocks during the production of the blocks Jun 20, 2024
@MitchTurner MitchTurner assigned MitchTurner and unassigned xgreenx Aug 14, 2024
MitchTurner added a commit that referenced this issue Aug 16, 2024
## Linked Issues/PRs
Part of #1902

## Description
Provide mechanism for taking predefined blocks and including them in
block production.

Does not provide the mechanism for introducing those predefined blocks
into the running system, e.g. parsing from file or something. That will
come after.

## Checklist
- [x] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests
- [x] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [x] I have reviewed the code myself
- [ ] I have created follow-up issues caused by this PR and linked them
here

### After merging, notify other teams

[Add or remove entries as needed]

- [ ] [Rust SDK](https://github.com/FuelLabs/fuels-rs/)
- [ ] [Sway compiler](https://github.com/FuelLabs/sway/)
- [ ] [Platform
documentation](https://github.com/FuelLabs/devrel-requests/issues/new?assignees=&labels=new+request&projects=&template=NEW-REQUEST.yml&title=%5BRequest%5D%3A+)
(for out-of-organization contributors, the person merging the PR will do
this)
- [ ] Someone else?

---------

Co-authored-by: green <xgreenx9999@gmail.com>
GoldenPath1109 added a commit to GoldenPath1109/fuel-core that referenced this issue Sep 7, 2024
## Linked Issues/PRs
Part of FuelLabs/fuel-core#1902

## Description
Provide mechanism for taking predefined blocks and including them in
block production.

Does not provide the mechanism for introducing those predefined blocks
into the running system, e.g. parsing from file or something. That will
come after.

## Checklist
- [x] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests
- [x] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [x] I have reviewed the code myself
- [ ] I have created follow-up issues caused by this PR and linked them
here

### After merging, notify other teams

[Add or remove entries as needed]

- [ ] [Rust SDK](https://github.com/FuelLabs/fuels-rs/)
- [ ] [Sway compiler](https://github.com/FuelLabs/sway/)
- [ ] [Platform
documentation](https://github.com/FuelLabs/devrel-requests/issues/new?assignees=&labels=new+request&projects=&template=NEW-REQUEST.yml&title=%5BRequest%5D%3A+)
(for out-of-organization contributors, the person merging the PR will do
this)
- [ ] Someone else?

---------

Co-authored-by: green <xgreenx9999@gmail.com>
GoldenPath1109 added a commit to GoldenPath1109/fuel-core that referenced this issue Sep 7, 2024
Follow-up PR for FuelLabs/fuel-core#2081.

Closes FuelLabs/fuel-core#1902

Add a CLI argument to process predefined blocks.

## Checklist
- [x] New behavior is reflected in tests

### Before requesting review
- [x] I have reviewed the code myself

---------

Co-authored-by: Mitch Turner <james.mitchell.turner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants