Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beef up execution tests #1911

Open
MitchTurner opened this issue May 29, 2024 · 2 comments
Open

Beef up execution tests #1911

MitchTurner opened this issue May 29, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@MitchTurner
Copy link
Member

Each of the tests should:

  1. Each produced block also is valdiated
  2. We produce the same block twice. First from intial block, the second from the first iteratiopn block
  3. All modification are done in InMemoryTransaction and we compare them after production and validation. The idea is that they are exactly the same

In addition, there are probably missing tests. Add any tests that seem to be missing.

@MitchTurner
Copy link
Member Author

It doesn't look like we have any tests that check for Errs.

@MitchTurner
Copy link
Member Author

Also, maybe as another PR, we should move the executor tests back to the executor service?

I think we should be testing the trait interfaces too. That might be another PR too. lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants