Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement our gas price algorithm for our GasPriceService #1955

Closed
MitchTurner opened this issue Jun 11, 2024 · 0 comments · Fixed by #1983
Closed

Implement our gas price algorithm for our GasPriceService #1955

MitchTurner opened this issue Jun 11, 2024 · 0 comments · Fixed by #1983
Assignees

Comments

@MitchTurner
Copy link
Member

Followup to:
#1938
#1948

And part of:
#1624

@MitchTurner MitchTurner self-assigned this Jun 11, 2024
MitchTurner added a commit that referenced this issue Jun 25, 2024
Part of: #1955

The updater has two ports it owns:
- `L2BlockSource`
- `MetadataStorage`

`L2BlockSource` is for getting the latest block as they are committed
and using that to update the gas price algorithm.
`MetadataStorage` is for maintaining the state of the updater in the
case the service shuts down or needs to be restarted. For now it just
naively stores the `AlgorithmUpdaterV1`, and just the most recent
version. I don't know if we need to consider storing older versions of
it for the scenario we need to roll back the chain.

I started adding the DA Record stuff, but we're not using it so we can
YAGNI it for now, otherwise it would just be implementing a bunch of
adapters that don't do anything.

This implements the service without any live adapters for the ports.

Will follow this up with another PR that actually implements the ports.

## Checklist
- [ ] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests
- [ ] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [x] I have reviewed the code myself
- [ ] I have created follow-up issues caused by this PR and linked them
here

### After merging, notify other teams

[Add or remove entries as needed]

- [ ] [Rust SDK](https://github.com/FuelLabs/fuels-rs/)
- [ ] [Sway compiler](https://github.com/FuelLabs/sway/)
- [ ] [Platform
documentation](https://github.com/FuelLabs/devrel-requests/issues/new?assignees=&labels=new+request&projects=&template=NEW-REQUEST.yml&title=%5BRequest%5D%3A+)
(for out-of-organization contributors, the person merging the PR will do
this)
- [ ] Someone else?

---------

Co-authored-by: human <jamesturner@Zenobia.hsd1.wa.comcast.net>
Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
GoldenPath1109 added a commit to GoldenPath1109/fuel-core that referenced this issue Sep 7, 2024
Part of: FuelLabs/fuel-core#1955

The updater has two ports it owns:
- `L2BlockSource`
- `MetadataStorage`

`L2BlockSource` is for getting the latest block as they are committed
and using that to update the gas price algorithm.
`MetadataStorage` is for maintaining the state of the updater in the
case the service shuts down or needs to be restarted. For now it just
naively stores the `AlgorithmUpdaterV1`, and just the most recent
version. I don't know if we need to consider storing older versions of
it for the scenario we need to roll back the chain.

I started adding the DA Record stuff, but we're not using it so we can
YAGNI it for now, otherwise it would just be implementing a bunch of
adapters that don't do anything.

This implements the service without any live adapters for the ports.

Will follow this up with another PR that actually implements the ports.

## Checklist
- [ ] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests
- [ ] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [x] I have reviewed the code myself
- [ ] I have created follow-up issues caused by this PR and linked them
here

### After merging, notify other teams

[Add or remove entries as needed]

- [ ] [Rust SDK](https://github.com/FuelLabs/fuels-rs/)
- [ ] [Sway compiler](https://github.com/FuelLabs/sway/)
- [ ] [Platform
documentation](https://github.com/FuelLabs/devrel-requests/issues/new?assignees=&labels=new+request&projects=&template=NEW-REQUEST.yml&title=%5BRequest%5D%3A+)
(for out-of-organization contributors, the person merging the PR will do
this)
- [ ] Someone else?

---------

Co-authored-by: human <jamesturner@Zenobia.hsd1.wa.comcast.net>
Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
GoldenPath1109 added a commit to GoldenPath1109/fuel-core that referenced this issue Sep 7, 2024
Closes: FuelLabs/fuel-core#1955

This actually implements the port adapters from the updater service to
access our live databases while running.

Will follow up with another PR that replaces the current updater with
the new one.

## Checklist
- [ ] Breaking changes are clearly marked as such in the PR description
and changelog
- [ ] New behavior is reflected in tests
- [ ] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [ ] I have reviewed the code myself
- [ ] I have created follow-up issues caused by this PR and linked them
here

### After merging, notify other teams

[Add or remove entries as needed]

- [ ] [Rust SDK](https://github.com/FuelLabs/fuels-rs/)
- [ ] [Sway compiler](https://github.com/FuelLabs/sway/)
- [ ] [Platform
documentation](https://github.com/FuelLabs/devrel-requests/issues/new?assignees=&labels=new+request&projects=&template=NEW-REQUEST.yml&title=%5BRequest%5D%3A+)
(for out-of-organization contributors, the person merging the PR will do
this)
- [ ] Someone else?

---------

Co-authored-by: human <jamesturner@Zenobia.hsd1.wa.comcast.net>
Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
Co-authored-by: Hannes Karppila <2204863+Dentosal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant