Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code owner and enhance approval process #1982

Closed
xgreenx opened this issue Jun 20, 2024 · 1 comment · Fixed by #2179
Closed

Add code owner and enhance approval process #1982

xgreenx opened this issue Jun 20, 2024 · 1 comment · Fixed by #2179
Assignees

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Jun 20, 2024

No description provided.

@Voxelot Voxelot changed the title Add code owner and enchant approval process Add code owner and enhance approval process Jun 20, 2024
@netrome
Copy link
Contributor

netrome commented Sep 6, 2024

Discussed this in our retro. I'll have a look at it.

Definition of done

We have a structure for defining code owners, and enforce at least one approval from a code owner for touched parts of the code. Initially @xgreenx, @Dentosal and @MitchTurner will be code owners for the entire repo, but the structure should support migrating to more code owners of more specific pieces of the code.

@netrome netrome self-assigned this Sep 6, 2024
@netrome netrome linked a pull request Sep 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants