Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #1946

Closed
wants to merge 1 commit into from
Closed

Conversation

cloudclaim
Copy link

@cloudclaim cloudclaim commented Jun 7, 2024

fix some comments

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

Signed-off-by: cloudclaim <824973921@qq.com>
@CLAassistant
Copy link

CLAassistant commented Jun 7, 2024

CLA assistant check
All committers have signed the CLA.

@xgreenx
Copy link
Collaborator

xgreenx commented Jun 7, 2024

We don't want to have a lot of small PRs with fixes only for several typos. We want to fix all of them in one PR, and automate their finding in the future=) Thank you, we are closing this PR in favor of #1554

You are welcome to join the mentioned PR and collaborate with the owner of this PR on the finalization of it.

@xgreenx xgreenx closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants