Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify and Ensure Support for Node.js 20 #1104

Closed
camsjams opened this issue Jul 17, 2023 · 4 comments · Fixed by #1544 or #1495
Closed

Verify and Ensure Support for Node.js 20 #1104

camsjams opened this issue Jul 17, 2023 · 4 comments · Fixed by #1544 or #1495
Assignees
Labels
chore Issue is a chore

Comments

@camsjams
Copy link
Contributor

Motivation

LTS starts in October

Usage example

No response

Possible implementations

No response

@nedsalk nedsalk self-assigned this Aug 9, 2023
@nedsalk
Copy link
Contributor

nedsalk commented Aug 14, 2023

I've tried using v20 in our codebase and got failing tests because fetching wasn't working properly. The culprit was graphql-request in the providers package which has the library cross-fetch as its dependency which, in turn, is using v2 of node-fetch, which doesn't have support for node v19 and v20 at the time of writing. The PR for adding this support is this one. After it gets merged, I'll return to the issue and try again.

@pedronauck
Copy link
Contributor

pedronauck commented Oct 24, 2023

I also got this error when trying to install fuels using node20

CleanShot 2023-10-24 at 19 27 52@2x

@nedsalk
Copy link
Contributor

nedsalk commented Nov 21, 2023

Although the issue mentioned above is resolved, I'll wait for #1374 to merge before continuing on this as it's replacing node-fetch with the native fetch. We'd have to override the used node-fetch version to get the fix, so I'd just wait until it's completely removed. I added a blocked label until then.

@arboleya arboleya added settings chore Issue is a chore labels Dec 7, 2023
@nedsalk nedsalk linked a pull request Dec 19, 2023 that will close this issue
@arboleya arboleya removed the blocked label Jan 3, 2024
@nedsalk nedsalk linked a pull request Jan 4, 2024 that will close this issue
44 tasks
@arboleya
Copy link
Member

Closed in #1544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants