Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move predicate data setting into constructor #1506

Closed
nedsalk opened this issue Dec 12, 2023 · 0 comments · Fixed by #1826
Closed

Move predicate data setting into constructor #1506

nedsalk opened this issue Dec 12, 2023 · 0 comments · Fixed by #1826
Assignees
Labels
docs Requests pertinent to documentation feat Issue is a feature

Comments

@nedsalk
Copy link
Contributor

nedsalk commented Dec 12, 2023

The team agreed in one of the weekly syncs that it's more straightforward and easier to reason about predicate data if we'd be setting it only via the Predicate constructor.

// current
const predicate = new Predicate(...);
predicate.setData(data);

// proposed
const predicate = new Predicate(..., data);

This implies removing the predicate.setData method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Requests pertinent to documentation feat Issue is a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants