Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multiple heap types in a single multicall #2132

Closed
danielbate opened this issue Apr 22, 2024 · 0 comments · Fixed by #2050
Closed

Enable multiple heap types in a single multicall #2132

danielbate opened this issue Apr 22, 2024 · 0 comments · Fixed by #2050
Assignees
Labels
feat Issue is a feature

Comments

@danielbate
Copy link
Member

When instantiating a MultiCallInvocationScope where more than one of the functions returns a heap type we currently throw the following error:

if (++numberOfHeaps > 1) {
throw new FuelError(
ErrorCode.INVALID_MULTICALL,
'A multicall can have only one call that returns a heap type.'
);
}

V1 encoding supports multiple heap type returns as it concatenates all returned byte date in the return data receipt. Rather than across multiple receipts, as required in V1.

This should be supported in the V1 implementation and proved with tests. We also have a number of heap multicall tests that should be enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants