Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Re-Adding Resources When Estimate TX At Account.getTransactionCost #2983

Closed
Torres-ssf opened this issue Aug 19, 2024 · 0 comments · Fixed by #2982
Closed

Avoid Re-Adding Resources When Estimate TX At Account.getTransactionCost #2983

Torres-ssf opened this issue Aug 19, 2024 · 0 comments · Fixed by #2982
Assignees
Labels
bug Issue is a bug

Comments

@Torres-ssf
Copy link
Contributor

While implementing the getTransactionCost at the Account class on #2643, we forgot to replicate the same logic that it had before when adding fake resources to a TX dry-run execution.

The previous approach involved updating the amounts of existing resources rather than adding new ones.

As a result, this change led to the gasUsed being slightly higher when running getTransactionCost for a transaction that had already been funded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant