Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize transaction's graphql queries #3289

Closed
5 tasks done
arboleya opened this issue Oct 9, 2024 · 2 comments
Closed
5 tasks done

Optimize transaction's graphql queries #3289

arboleya opened this issue Oct 9, 2024 · 2 comments
Assignees
Labels
chore Issue is a chore

Comments

@arboleya
Copy link
Member

arboleya commented Oct 9, 2024

During some load tests, we realized a couple of issues (#3279, #3277) that we're fixing and optimizing.

In keeping with this theme, we should continue the effort and review our predefined GQL queries and fragments.

Every field removal is a breaking change and can break things for apps, so we need to be extra careful here.

Taking from the providers/operations.graphql:

  • getTransaction
  • getTransactionWithReceipts
  • getTransactions
  • getTransactionsByOwner
  • getRelayedTransactionStatus
@arboleya arboleya added the chore Issue is a chore label Oct 9, 2024
@Torres-ssf Torres-ssf self-assigned this Oct 9, 2024
@petertonysmith94
Copy link
Contributor

petertonysmith94 commented Nov 18, 2024

@Torres-ssf do you think this can be closed as part of #3336? I can't see any further optimizations.

@Torres-ssf
Copy link
Contributor

Closing this issue as the optimizations have already been addressed through the following closed PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

No branches or pull requests

3 participants