onDeploy does not work for predicates and scripts in fuels deploy

[luisburigo]

It would be interesting to implement this for predicates and scripts to enable some automations. Currently,onDeploy is executed after contracts are deployed.

fuels-ts/packages/fuels/src/cli/commands/deploy/index.ts

Lines 11 to 18 in 88d7535

	export async function deploy(config: FuelsConfig) {
	/**
	* Deploy contract and save their IDs to JSON file.
	*/
	const contractIds = await deployContracts(config);
	await saveContractIds(contractIds, config.output);
	config.onDeploy?.(config, contractIds);

My suggestion would be to implement something like this:

export async function deploy(config: FuelsConfig) {
  /**
   * Deploy contract and save their IDs to JSON file.
   */
  const contractIds = await deployContracts(config);
  await saveContractIds(contractIds, config.output);

  /**
   * Deploy scripts and save deployed files to disk.
   */
  const scripts = await deployScripts(config);
  saveScriptFiles(scripts, config);

  /**
   * Deploy predicates and save deployed files to disk.
   */
  const predicates = await deployPredicates(config);
  savePredicateFiles(predicates, config);
  
  config.onDeploy?.(config, {
    scripts,
    predicates,
    contracts: contractIds,
  });

  /**
   * After deploying scripts/predicates, we need to
   * re-generate factory classe with the loader coee
   */
  await generateTypes(config);

  return contractIds;
}

[Chirag-S-Kotian]

assign this to me

[petertonysmith94]

Hey @Chirag-S-Kotian,

We generally assign to outside contributors once the PR has been created :)

Let us know if you need any assistance.

[Chirag-S-Kotian]

Assign this to me and give me details for this issue

[nedsalk]

Assign this to me

Hey @Chirag-S-Kotian,
We generally assign to outside contributors once the PR has been created :)
Let us know if you need any assistance.

and give me details for this issue

The details of the issue are in the issue's description. Is there something unclear in it?

[petertonysmith94]

@Chirag-S-Kotian It looks like @YaTut1901 has already taken on this piece (#3383); maybe there is a good first issue that you'd like to contribute to.

[YaTut1901]

hello, @petertonysmith94 could you verify if that possible to continue with my PR?

[petertonysmith94]

@YaTut1901 - yes, please continue with your PR 🙏🏼

[YaTut1901]

then, could you please approve? From my side I do not see any changes