Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods without #[payable] annotation cannot accept coins #675

Closed
anton-trunov opened this issue Dec 15, 2022 · 3 comments · Fixed by #763
Closed

Methods without #[payable] annotation cannot accept coins #675

anton-trunov opened this issue Dec 15, 2022 · 3 comments · Fixed by #763
Assignees
@Dhaiwat10
Labels
feat Issue is a feature

Comments

@anton-trunov
Copy link

Motivation

Once FuelLabs/sway#3450 is merged the SDK also needs to forbid accepting coins in non-payable functions. The current plan is to introduce function attributes into the JSON ABI schema to mark payable functions as such. I'm happy to take any comments/suggestions on this.

Spec issue: FuelLabs/fuel-specs#446
Compiler change: FuelLabs/sway#3450
fuels-rs issue: FuelLabs/fuels-rs#742

Usage example

No response

Possible implementations

No response
@anton-trunov anton-trunov mentioned this issue Dec 15, 2022
Closed
@digorithm digorithm added the feat Issue is a feature label Dec 15, 2022
@anton-trunov
Copy link
Author

FYI, all the relevant PRs have been merged

@Dhaiwat10
Copy link
Contributor

Picking this one up

@Dhaiwat10 Dhaiwat10 self-assigned this Feb 3, 2023
@arboleya
Copy link
Member

arboleya commented Feb 4, 2023

Should this change something on the Typegen land, like generating code annotations and extra type helpers?

We can sync up on this as you advance with your implementation.

@Dhaiwat10 Dhaiwat10 mentioned this issue Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dhaiwat10 Dhaiwat10

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: methods without #[payable] annotation cannot accept coins FuelLabs/fuels-ts
4 participants
@arboleya @anton-trunov @digorithm @Dhaiwat10