Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate over @fuels/assets package into the TS SDK #1747

Merged
merged 17 commits into from
Feb 20, 2024
Merged

feat: migrate over @fuels/assets package into the TS SDK #1747

merged 17 commits into from
Feb 20, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Feb 14, 2024 •
edited by luizstacio
Loading

This PR migrates the @fuels/assets npm package to the TS SDK repo.

Todo:

  • Someone needs to add the AWS credentials to the TS SDK repo. These are required for the 'Upload assets to S3' workflow added with this PR. cc @luizstacio

Closes #1541

@Dhaiwat10 Dhaiwat10 mentioned this pull request Feb 14, 2024
Closed
@Dhaiwat10 Dhaiwat10 self-assigned this Feb 14, 2024
@Dhaiwat10 Dhaiwat10 added the feat Issue is a feature label Feb 14, 2024
@Dhaiwat10 Dhaiwat10 marked this pull request as ready for review February 14, 2024 17:59
@luizstacio
Copy link
Member

@Dhaiwat10 the credentials are already setup on the CI.

@Dhaiwat10
Copy link
Member Author

@luizstacio Oh didn't know, thanks! :)

arboleya
arboleya reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some tests to this?

@Dhaiwat10
Copy link
Member Author

Dhaiwat10 commented Feb 16, 2024 •
edited
Loading

Adding tests and also renaming/re-organizing some of the functions while I'm at it. Marking as a draft until ready

@Dhaiwat10 Dhaiwat10 marked this pull request as draft February 16, 2024 06:11
@Dhaiwat10 Dhaiwat10 marked this pull request as ready for review February 17, 2024 01:22
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.98%(+0.07%) 71.16%(+0.15%) 77.9%(+0.15%) 80.05%(+0.08%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
✅ ✨ packages/account/src/providers/chains.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/account/src/providers/assets/index.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
🔴 ✨ packages/account/src/providers/assets/utils/network.ts 91.3%
(+91.3%)		 83.33%
(+83.33%)		 100%
(+100%)		 91.3%
(+91.3%)
✅ ✨ packages/account/src/providers/assets/utils/resolveIconPaths.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
🔴 ✨ packages/account/src/providers/assets/utils/url.ts 100%
(+100%)		 88.88%
(+88.88%)		 100%
(+100%)		 100%
(+100%)

@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) February 20, 2024 14:56
@Dhaiwat10 Dhaiwat10 merged commit 116d642 into master Feb 20, 2024
13 of 14 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/migrate-assets-v2 branch February 20, 2024 15:06
@fuel-service-user fuel-service-user mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export Asset/Networks Config Interface
5 participants
@Dhaiwat10 @luizstacio @arboleya @danielbate @nedsalk